Add support for GenericFunctionTypeElementImpl #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Sep 8, 2017
lib/src/model.dart
Outdated
| @@ -1394,16 +1394,26 @@ abstract class GetterSetterCombo implements ModelElement { | |||
|
|
|||
| if (hasGetter && !getter.element.isSynthetic) { | |||
| assert(getter.documentationFrom.length == 1); | |||
| String docs = getter.documentationFrom.first.computeDocumentationComment; | |||
| if (docs != null) buffer.write(docs); | |||
| // We have to check against dropTextList here since documentationFrom | |||
|
While moving to the new version of the analyzer is required to make tests pass both in the SDK and in the published package, apparently the alpha version of the analyzer has some sort of bug or change that breaks our AppVeyor build. |
jcollins-g
added a commit
that referenced
this pull request
Sep 8, 2017
* Initial implementation * Test updates * Rearrange test * Tune up tests to work without new analyzer * Change to alpha analyzer * dartfmt * Use original analyzer version for mainline branch * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1495. Allow GenericFunctionTypeElements to work by refactoring ModelFunction into ModelFunctionTyped and ModelFunction classes. Also move to the new version of the analyzer for dartdoc (required to enable tests to pass) and fix the SDK documentation filter so that tests will still pass for the head version of analyzer.