Add flag and rebuild test package docs #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
reviewed
Jun 6, 2017
| @@ -266,6 +289,14 @@ ArgParser _createArgsParser() { | |||
| "Generates `index.json` with indentation and newlines. The file is larger, but it's also easier to diff.", | |||
| negatable: false, | |||
| defaultsTo: false); | |||
| parser.addFlag( | |||
| 'hide-sdk-text', | |||
| help: | |||
devoncarew
reviewed
Jun 6, 2017
lib/src/model.dart
Outdated
| return _rawDocs; | ||
| } | ||
|
|
||
| /// Returns the docs, stripped of their leading comments syntax. | ||
| @override | ||
| String get documentation => documentationFrom._documentationLocal; | ||
| String get documentation { | ||
| String x = documentationFrom._documentationLocal; |
There was a problem hiding this comment.
Oops. I keep forgetting to undo my manual conditional breakpoints completely.
devoncarew
reviewed
Jun 6, 2017
lib/src/config.dart
Outdated
| if (categoryOrder == null) { | ||
| categoryOrder = new UnmodifiableListView<String>([]); | ||
| } | ||
| if (dropTextFrom == null) { |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1456 and should enable dartdoc tests to work reliably in the SDK.
As discussed before, add a flag to hide the imported SDK docs in the integration tests.