Skip to content

Add annotations to parameter documentation #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Conversation

jcollins-g
Copy link
Contributor

Fix #1432 by removing some special casing, and add tests.

screenshot from 2017-06-01 14 37 35
screenshot from 2017-06-01 14 53 39

@jcollins-g jcollins-g requested a review from keertip June 1, 2017 21:55
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Jun 1, 2017
@devoncarew
Copy link
Member

lgtm

Copy link
Collaborator

@keertip keertip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jcollins-g jcollins-g merged commit 278713e into master Jun 13, 2017
@jcollins-g jcollins-g deleted the required-in-params branch June 13, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants