Skip to content

Miscellaneous warnings updates (without crash) #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2017

Conversation

jcollins-g
Copy link
Contributor

This PR is the same as #1421 was, except includes the workaround for dart-lang/sdk#29620 and the review comments. PTAL.

@devoncarew
Copy link
Member

lgtm

Copy link
Collaborator

@keertip keertip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Like the way the warnings have so much more detail.

@jcollins-g jcollins-g merged commit e15f074 into master May 22, 2017
@kevmoo kevmoo deleted the warnings-update-nocrash branch May 23, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants