eliminate crash on warnings generated by README.md #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
changed the title
devoncarew
approved these changes
May 10, 2017
jcollins-g
commented
May 10, 2017
| } | ||
| if (refElement is PrefixElement) { | ||
| // We found a prefix element, but what we really want is the library element. | ||
| refElement = (refElement as PrefixElement).enclosingElement; |
There was a problem hiding this comment.
This is actually a second bug that was lurking behind the first one: commentRefs can contain PrefixElements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1409.
This fixes the bug by eliminating the second pathway to _renderMarkdownToHtml, forcing packages down the same path as every other Documentable.