Fix line number in the "Link to Crossdart" link #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to point to the beginning of the comment section, and also was off by 1 (I guess because `LineNumberCache` counts them from 0, but www.crossdart.info starts from 1). Now it points to the actual declaration.
astashov
force-pushed
the
fix-link-to-crossdart-line
branch
from
4ca1b7c to
c341f5c
Compare
When there're inherited methods in a class, and they are inherited from a class in other package (or SDK), we incorrectly built the link. This fixes it, and now I try to infer the right path from `uri` and `path` properties of `node.element.source`. If `uri` is not `dart:` or `package:`, I just won't add the crossdart link (for safety). I removed a test, because couldn't figure out how to make `package:` `uri` in the tests - it's always `file:///` :(
|
lgtm! |
|
Regenerated the packages on dartdocs.org, btw! Now it looks like this: https://www.dartdocs.org/documentation/dartabase_model/0.6.0/dartabaseModel/Model/find.html Event for SDK: https://www.dartdocs.org/documentation/sdk/1.18.0-dev.0.0/dart-async/Future/Future.sync.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @keertip, I'm really sorry, but there's one more thing I need to fix.
Hopefully, the last one :)
The "Link to Crossdart" used to point to the beginning of the comment section, and also was
off by 1 (I guess because
LineNumberCachecounts them from 0, butwww.crossdart.info starts from 1).
Now it points to the actual declaration.