Skip to content

Left sidebar not showing on some docs #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Levi-Lesches opened this issue Jul 20, 2023 · 1 comment
Closed

Left sidebar not showing on some docs #3467

Levi-Lesches opened this issue Jul 20, 2023 · 1 comment

Comments

@Levi-Lesches
Copy link

It seems the changes in PR #3384 break some sidebars, at least in my case:
Here's what the sidebars should look like
image
And here's what a method/property/constructor page actually looks like:
image

Clearly the ProtoSocket-class-sidebar.html file exists and loads fine, but I noticed the constructor/method/property pages don't even request it!
Here are the network requests for the ProtoSocket page:
image
And here are the requests for the init method:
image

Here's the code for the main-content on the ProtoSocket page:

<div id="dartdoc-main-content" class="main-content" data-above-sidebar="burt_network/burt_network-library-sidebar.html" data-below-sidebar="burt_network/ProtoSocket-class-sidebar.html">

And here's the code for the init method:

<div id="dartdoc-main-content" class="main-content" data-above-sidebar="burt_network/ProtoSocket-class-sidebar.html" data-below-sidebar="">

When I edit the HTML to put the sidebar on the right as well, it loads... but only on the right side. My repository is here, feel free to ask for more info.

Originally posted by @Levi-Lesches in #3079 (comment)

@Levi-Lesches Levi-Lesches changed the title @srawlins I'm really impressed by the sidebars PR #3384, but it broke my docs (in version 6.3.0) :( Left sidebar not showing on some docs Jul 20, 2023
@Levi-Lesches
Copy link
Author

Levi-Lesches commented Jul 25, 2023

Not sure what changed but this is working now. The output above was generated with dart pub global run dartdoc and some more options, while the below was generated with dart doc, but I didn't upgrade the version since making this issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant