Skip to content

up/down arrow keys in search doesn't work any more (regression) #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hixie opened this issue May 25, 2022 · 6 comments
Closed

up/down arrow keys in search doesn't work any more (regression) #3052

Hixie opened this issue May 25, 2022 · 6 comments
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@Hixie
Copy link
Contributor

Hixie commented May 25, 2022

STEPS TO REPRODUCE

  1. Go to master-api.flutter or api.dart.dev/dev
  2. Tab three times to focus the search field
  3. Type "e"
  4. Press the down arrow

EXPECTED RESULTS
It highlights the first result

ACTUAL RESULTS
Nothing happens when you press the down arrow

This is a regression; it works fine on stable (api.flutter.dev or api.dart.dev/stable).

Maybe caused by #3016 ? cc @devoncarew
@devoncarew
Copy link
Member

Maybe caused by #3016 ? cc @devoncarew

Ah, yup, I would expect so. I'll take a look.

@devoncarew devoncarew self-assigned this May 26, 2022
@devoncarew
Copy link
Member

Or - @keertip - when will your intern come online? This might be a good issue for them - in-line with their starter project?

@keertip
Copy link
Collaborator

keertip commented May 26, 2022

Intern will be starting next week.

@devoncarew devoncarew removed their assignment May 26, 2022
@devoncarew devoncarew added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) customer-flutter Issues originating from important to Flutter labels May 26, 2022
@keertip keertip added the intern label May 26, 2022
@parlough parlough mentioned this issue May 31, 2022
Closed
@justinmc
Copy link

Also pressing the enter key used to select the first option but now it's broken too.

@keertip
Copy link
Collaborator

keertip commented Jun 1, 2022 •
edited
Loading

@klr981, could you please take a look? Thanks!

klr981 added a commit to klr981/dartdoc that referenced this issue Jun 2, 2022
@klr981
Issue dart-lang#3052: up/down arrox bug fix
3e2c2ba
@klr981 klr981 mentioned this issue Jun 2, 2022
Merged
klr981 added a commit to klr981/dartdoc that referenced this issue Jun 2, 2022
@klr981
Issue dart-lang#3052: Added missing files for build
7aeb937
devoncarew pushed a commit that referenced this issue Jun 2, 2022
@klr981
Issue #3052: up/down arrox bug fix (#3054)
f0098f9 
* Issue #3052: up/down arrox bug fix

* Issue #3052: Added missing files for build
@srawlins srawlins added the P2 A bug or feature request we're likely to work on label Jun 29, 2022
@srawlins
Copy link
Member

@klr981 fixed this. 🎉

Release coming soon.

@goderbauer goderbauer mentioned this issue Jul 6, 2022
Merged
klr981 added a commit to klr981/dartdoc that referenced this issue Jul 30, 2022
@klr981
Issue dart-lang#3052: Added missing files for build
9cb0b58
klr981 added a commit to klr981/dartdoc that referenced this issue Jul 30, 2022
@klr981
Issue dart-lang#3052: Added missing files for build
df22429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@srawlins @justinmc @Hixie @devoncarew @keertip