Skip to content

Allow a direct "warnings as errors" flag #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcollins-g opened this issue Oct 26, 2021 · 1 comment
Open

Allow a direct "warnings as errors" flag #2846

jcollins-g opened this issue Oct 26, 2021 · 1 comment
Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@jcollins-g
Copy link
Contributor

This flag should cause dartdoc to treat all warnings as errors for the purposes of returning an exit code for CI.

Some questions:

  1. Do we want to still internally track as warnings vs errors and change the exit code only? Or simply convert to errors.
  2. Do we want to allow packages to individually opt out via dartdoc_options.yaml, and how does the flag interact with the other warning control flags?

@mit-mit

@jcollins-g jcollins-g added type-enhancement A request for a change that isn't a bug P2 A bug or feature request we're likely to work on labels Oct 26, 2021
@jcollins-g
Copy link
Contributor Author

$ dart help analyze
Analyze Dart code in a directory.

Usage: dart analyze [arguments] [<directory>]
-h, --help                   Print this usage information.
    --fatal-infos            Treat info level issues as fatal.
    --[no-]fatal-warnings    Treat warning level issues as fatal.
                             (defaults to on)

as @mit-mit suggested, aligning with dart analyze here seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant