Skip to content

Macros don't expand dartdoc directives injected by tools #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gspencergoog opened this issue Mar 25, 2019 · 1 comment · Fixed by #2274 or flutter/flutter#63111
Closed

Macros don't expand dartdoc directives injected by tools #1945

gspencergoog opened this issue Mar 25, 2019 · 1 comment · Fixed by #2274 or flutter/flutter#63111
Assignees
@srawlins
Labels
P2 A bug or feature request we're likely to work on

Comments

@gspencergoog
Copy link
Collaborator

gspencergoog commented Mar 25, 2019 •
edited
Loading

In this page , there are {@inject-html} tags still present in the output. These examples are generated by the snippets tool, but they are part of a template, and it's not happening elsewhere, so I assume that this is because templates don't get a second pass when they are instantiated to expand dartdoc directives.

Related to flutter/flutter#29919
@gspencergoog gspencergoog mentioned this issue Apr 1, 2019
Merged
9 tasks
@jcollins-g jcollins-g added the P2 A bug or feature request we're likely to work on label Sep 30, 2019
@srawlins srawlins self-assigned this Jul 23, 2020
@goderbauer goderbauer mentioned this issue Jul 23, 2020
Merged
13 tasks
srawlins added a commit to srawlins/dartdoc that referenced this issue Jul 24, 2020
@srawlins
Process directives after macro-processing; fixes dart-lang#1945
5e7e912
@srawlins srawlins mentioned this issue Jul 24, 2020
Merged
@goderbauer goderbauer mentioned this issue Jul 30, 2020
Closed
@srawlins
Copy link
Member

Should be fixed with a bump to dartdoc 0.32.3, which I have not released yet.

@srawlins srawlins reopened this Jul 30, 2020
@goderbauer goderbauer mentioned this issue Aug 6, 2020
Merged
13 tasks
@srawlins srawlins closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
3 participants
@srawlins @gspencergoog @jcollins-g