Skip to content

Private superclasses lead to dead references #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Jul 27, 2017 · 2 comments
Closed

Private superclasses lead to dead references #1476

Hixie opened this issue Jul 27, 2017 · 2 comments
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@Hixie
Copy link
Contributor

Hixie commented Jul 27, 2017

Consider this setup:

class _Private {
  /// This is the documentation for "foo".
  final bool foo;
}

/// See the [foo] documentation.
class Public extends _Private { }

You'll get the error message (paraphrasing a little) "warning: no canonical library found for test._Private.foo, not linking from _Private.foo referred to by Public".

But Public.foo appears in the documentation with the text from _Private.foo, so it seems like Public should just link to its own foo when it refers to [foo].

Marking P1 as "Broken links, few or on edge cases".

@Hixie Hixie added customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jul 27, 2017
@jcollins-g
Copy link
Contributor

This is related to #1173, but probably fixable independent of that.

@jcollins-g
Copy link
Contributor

Fixed in #1524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

2 participants