-
Notifications
You must be signed in to change notification settings - Fork 124
No automatic hyperlinking in HTML fragments #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The dartdoc package uses package:markdown, which mostly supports GitHub-flavored Markdown tables. Are these enabled in dartdocs? |
@Hixie , I don't understand. I don't see a |
@srawlins I literally meant "HTML fragment", as in, a fragment of HTML, not URL fragment identifiers. |
Oh sorry. That's not part of the Markdown spec. You'll notice the backticks aren't converted to If you use the GFM markdown syntax, it might work. |
What does that mean? :-) |
Also, what markdown spec? |
The markdown package tries to follow the CommonMark spec, or, if you use In this case, using GFM tables: | | `newWidget == null` | `newWidget != null`
|-----------------|---------------------|-----------------------
| `child == null` | Returns null. | Returns new [Element].
| `child != null` | Old child is removed, returns null. | Old child updated if possible, returns child or new [Element]. |
|
Pretty sure I tried that and it didn't work, and when I complained, I was told to use BTW, dartdoc definitely doesn't follow that spec, at least not exclusively. In particular, hyperlinks to members aren't a syntax covered by that spec as far as I can tell. Nor are macros. |
OK good, so there is a known issue. Yeah I guess custom link resolvers are a customization. We just allow shortcut reference links without a link reference definition, which then gets sent to a link resolver to answer "this might be a link. do you think it's a link? where should it point to?" |
The table in the following snippet fails to hyperlink the contents of the cells:
https://master-docs-flutter-io.firebaseapp.com/flutter/widgets/Element/updateChild.html
(I think our ideal solution would be to have some way to mark tables up in markdown instead of using HTML, for what it's worth.)
The text was updated successfully, but these errors were encountered: