Skip to content

option to override the favicon #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sethladd opened this issue Dec 15, 2015 · 7 comments · Fixed by #1142
Closed

option to override the favicon #1063

sethladd opened this issue Dec 15, 2015 · 7 comments · Fixed by #1142
Labels
customer-flutter Issues originating from important to Flutter type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

Flutter would like a different favicon. Could we add an option to override it?
@sethladd sethladd added the type-enhancement A request for a change that isn't a bug label Dec 15, 2015
@sethladd
Copy link
Contributor Author

cc @eseidel

@eseidel
Copy link

eseidel commented Dec 15, 2015

Presumably this is already possible using --header? I haven't tried.
On Dec 15, 2015 7:51 AM, "Seth Ladd" [email protected] wrote:

cc @eseidel https://github.com/eseidel

—
Reply to this email directly or view it on GitHub
#1063 (comment).

@sethladd
Copy link
Contributor Author

Header inserts a block of code into <head> but it doesn't override <head>. The favicon is already set, and it's hard coded. So, we'll need a graceful way to override that.

@keertip
Copy link
Collaborator

keertip commented Dec 15, 2015

One more option :). Yes, we could add an option to override the favicon.

@eseidel
Copy link

eseidel commented Dec 15, 2015

We can also pretty easily post process the output directory to replace the
image. Not sure how common the need is or how much otber post processing
were going to need to do. Just depends on if we want to have a "flutter
docs" wrapper around dartdoc or not.
On Dec 15, 2015 8:10 AM, "Keerti Parthasarathy" [email protected]
wrote:

One more option :). Yes, we could add an option to override the favicon.

—
Reply to this email directly or view it on GitHub
#1063 (comment).

@sethladd
Copy link
Contributor Author

Ideally, dartdoc is a tool that is customizable by frameworks. It's in scope to allow customization of favicon, imo.

@sethladd sethladd added the customer-flutter Issues originating from important to Flutter label Dec 20, 2015
@devoncarew devoncarew mentioned this issue Apr 8, 2016
Merged
@eseidelGoogle
Copy link
Contributor

Presumably flutter (http://docs.flutter.io/flutter/) can now change:
https://github.com/flutter/flutter/blob/master/dev/dartdoc.dart#L45
to include favicon from https://github.com/flutter/website/blob/master/favicon.ico and our docs should look right. :D Thanks @devoncarew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer-flutter Issues originating from important to Flutter type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a --favicon flag dart-lang/dartdoc
4 participants
@sethladd @eseidel @keertip @eseidelGoogle