Skip to content

Commit 01694d4

Browse files
authored
Skip sdk-analyzer job (#2863)
1 parent ff0d94b commit 01694d4

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

.github/workflows/test.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
matrix:
2121
os: [ubuntu-latest]
2222
sdk: [dev, stable]
23-
job: [main, flutter, sdk-analyzer, packages, sdk-docs]
23+
job: [main, flutter, packages, sdk-docs]
2424
include:
2525
- os: macos-latest
2626
sdk: dev
@@ -34,8 +34,8 @@ jobs:
3434
# results.
3535
- sdk: stable
3636
job: flutter
37-
- sdk: stable
38-
job: sdk-analyzer
37+
#- sdk: stable
38+
# job: sdk-analyzer
3939
- sdk: stable
4040
job: sdk-docs
4141

testing/test_package/lib/features/nullable_elements.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ void set nullableSetter(String? value) {
1515
}
1616

1717
/// This should have return type of `Future?`.
18+
// ignore: unnecessary_question_mark
1819
dynamic? oddAsyncFunction() async {}
1920

2021
/// This should also have return type of `Future?`.

testing/test_package/lib/features/opt_out_of_nnbd.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66

77
library opt_out_of_nnbd;
88

9+
// ignore: dead_code
910
String notOptedIn = false ? 'hi' : null;

testing/test_package/lib/src/somelib.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,13 @@ class ExtendedBaseReexported extends BaseReexported {}
1818

1919
/// A private extension.
2020
extension _Unseen on Object {
21+
// ignore: unused_element
2122
void doYouSeeMe() {}
2223
}
2324

2425
/// An extension without a name
2526
extension on List {
27+
// ignore: unused_element
2628
void somethingNew() {}
2729
}
2830

tool/grind.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,8 +258,10 @@ void analyzeTestPackages() async {
258258
workingDirectory: testPackagePath,
259259
);
260260
await SubprocessLauncher('analyze-test-package').runStreamed(
261-
sdkBin('dartanalyzer'),
262-
['.'],
261+
sdkBin('dart'),
262+
// TODO(srawlins): Analyze the whole directory by ignoring the pubspec
263+
// reports.
264+
['analyze', 'lib'],
263265
workingDirectory: testPackagePath,
264266
);
265267
}

0 commit comments

Comments
 (0)