Skip sdk-analyzer job (#2863)

Author: srawlins

.github/workflows/test.yaml

@@ -20,7 +20,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         sdk: [dev, stable]
-        job: [main, flutter, sdk-analyzer, packages, sdk-docs]
+        job: [main, flutter, packages, sdk-docs]
         include:
           - os: macos-latest
             sdk: dev
@@ -34,8 +34,8 @@ jobs:
             # results.
           - sdk: stable
             job: flutter
-          - sdk: stable
-            job: sdk-analyzer
+            #- sdk: stable
+            #  job: sdk-analyzer
           - sdk: stable
             job: sdk-docs
 

testing/test_package/lib/features/nullable_elements.dart

@@ -15,6 +15,7 @@ void set nullableSetter(String? value) {
 }
 
 /// This should have return type of `Future?`.
+// ignore: unnecessary_question_mark
 dynamic? oddAsyncFunction() async {}
 
 /// This should also have return type of `Future?`.

testing/test_package/lib/features/opt_out_of_nnbd.dart

@@ -6,4 +6,5 @@
 
 library opt_out_of_nnbd;
 
+// ignore: dead_code
 String notOptedIn = false ? 'hi' : null;

testing/test_package/lib/src/somelib.dart

@@ -18,11 +18,13 @@ class ExtendedBaseReexported extends BaseReexported {}
 
 /// A private extension.
 extension _Unseen on Object {
+  // ignore: unused_element
   void doYouSeeMe() {}
 }
 
 /// An extension without a name
 extension on List {
+  // ignore: unused_element
   void somethingNew() {}
 }
 

tool/grind.dart

@@ -258,8 +258,10 @@ void analyzeTestPackages() async {
       workingDirectory: testPackagePath,
     );
     await SubprocessLauncher('analyze-test-package').runStreamed(
-      sdkBin('dartanalyzer'),
-      ['.'],
+      sdkBin('dart'),
+      // TODO(srawlins): Analyze the whole directory by ignoring the pubspec
+      // reports.
+      ['analyze', 'lib'],
       workingDirectory: testPackagePath,
     );
   }