Move from dartfmt to dart format #125
Conversation
|
This currently has terrible UX when the code has errors due to https://github.com/dart-lang/sdk/issues/46379 |
|
Is this unblocked since dart-lang/dart_style#1035 is closed? |
|
Now this is blocked by dart-lang/sdk#46636 After this is unblocked we'll need to figure out the rollout plan - given the bugs on existing stable SDKs I don't think we can roll this out universally. We might need to implement some kind of SDK version check. Or we could consider adding a setting which could be more annoying for users, but simpler to implement. |
If the `dart` command exists, parse the output of `dart --version` and for SDK version `2.14` and higher use `dart format`. On older SDKs fallback to the existing behavior. There will be some `2.14.0-dev` SDKs which are not compatible with this check, but they aren't likely be to in use anymore for local development.
| \ '\vDart SDK version: (\d+)\.(\d+)\.\d+.*') | ||
| if empty(l:match) | ||
| call s:error('Unable to determine dart version') | ||
| return [] |
There was a problem hiding this comment.
Rather than return with an error, would it be worth using the fallback in this case?
There was a problem hiding this comment.
I think the error might be better? IIRC, it's difficult/tedious to distinguish between stdout and stderr in vim, so diagnostics emitted by dart format/dartfmt get inserted at the top of the file. In particular, if we fail to detect the Dart version and fall back to dartfmt when dart format is expected, the UX will be worse than not formatting at all.
Nate can confirm though - I'm not sure if the linked issues have changed how this works.
There was a problem hiding this comment.
I don't expect any existing SDK releases to hit this. If the version string format changes in the future SDK releases, the fallback won't be the right behavior.
Closes #124