Skip to content

Commit 48b5006

Browse files
authored
update core and recommended from the recent review (dart-archive/lints#136)
* update core ad recommended from the recent review * unnecessary_constructor_name was already in the set
1 parent 1a05d9e commit 48b5006

File tree

5 files changed

+19
-10
lines changed

5 files changed

+19
-10
lines changed

pkgs/lints/CHANGELOG.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
1-
## 2.1.2-wip
2-
3-
- Add 'has quick-fix' checkboxes to the package's readme.
1+
## 3.0.0-wip
2+
3+
- Added to core.yaml:
4+
- `collection_methods_unrelated_type`
5+
- `implicit_call_tearoffs`
6+
- `use_string_in_part_of_directives`
7+
- Removed from core.yaml:
8+
- `iterable_contains_unrelated_type`
9+
- `list_remove_unrelated_type`
10+
- Add info about which lints have quick fixs to the package's readme.
411

512
## 2.1.1
613

pkgs/lints/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ To use these lints create an `analysis_options.yaml` file with:
109109
| [`await_only_futures`](https://dart.dev/lints/await_only_futures) | Await only futures. | ✅ |
110110
| [`camel_case_extensions`](https://dart.dev/lints/camel_case_extensions) | Name extensions using UpperCamelCase. | |
111111
| [`camel_case_types`](https://dart.dev/lints/camel_case_types) | Name types using UpperCamelCase. | |
112+
| [`collection_methods_unrelated_type`](https://dart.dev/lints/collection_methods_unrelated_type) | Invocation of various collection methods with arguments of unrelated types. | |
112113
| [`curly_braces_in_flow_control_structures`](https://dart.dev/lints/curly_braces_in_flow_control_structures) | DO use curly braces for all flow control structures. | ✅ |
113114
| [`depend_on_referenced_packages`](https://dart.dev/lints/depend_on_referenced_packages) | Depend on referenced packages. | |
114115
| [`empty_catches`](https://dart.dev/lints/empty_catches) | Avoid empty catch blocks. | ✅ |
115116
| [`file_names`](https://dart.dev/lints/file_names) | Name source files using `lowercase_with_underscores`. | |
116117
| [`hash_and_equals`](https://dart.dev/lints/hash_and_equals) | Always override `hashCode` if overriding `==`. | ✅ |
117-
| [`iterable_contains_unrelated_type`](https://dart.dev/lints/iterable_contains_unrelated_type) | Invocation of Iterable<E>.contains with references of unrelated types. | |
118-
| [`list_remove_unrelated_type`](https://dart.dev/lints/list_remove_unrelated_type) | Invocation of `remove` with references of unrelated types. | |
118+
| [`implicit_call_tearoffs`](https://dart.dev/lints/implicit_call_tearoffs) | Explicitly tear-off `call` methods when using an object as a Function. | ✅ |
119119
| [`no_duplicate_case_values`](https://dart.dev/lints/no_duplicate_case_values) | Don't use more than one case with same value. | ✅ |
120120
| [`non_constant_identifier_names`](https://dart.dev/lints/non_constant_identifier_names) | Name non-constant identifiers using lowerCamelCase. | ✅ |
121121
| [`null_check_on_nullable_type_parameter`](https://dart.dev/lints/null_check_on_nullable_type_parameter) | Don't use null check on a potentially nullable type parameter. | ✅ |
@@ -128,6 +128,7 @@ To use these lints create an `analysis_options.yaml` file with:
128128
| [`provide_deprecation_message`](https://dart.dev/lints/provide_deprecation_message) | Provide a deprecation message, via @Deprecated("message"). | |
129129
| [`unnecessary_overrides`](https://dart.dev/lints/unnecessary_overrides) | Don't override a method to do a super method invocation with the same parameters. | ✅ |
130130
| [`unrelated_type_equality_checks`](https://dart.dev/lints/unrelated_type_equality_checks) | Equality operator `==` invocation with references of unrelated types. | |
131+
| [`use_string_in_part_of_directives`](https://dart.dev/lints/use_string_in_part_of_directives) | Use string in part of directives. | ✅ |
131132
| [`valid_regexps`](https://dart.dev/lints/valid_regexps) | Use valid regular expression syntax. | |
132133
| [`void_checks`](https://dart.dev/lints/void_checks) | Don't assign to void. | |
133134
<!-- core -->

pkgs/lints/lib/core.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ linter:
1313
- await_only_futures
1414
- camel_case_extensions
1515
- camel_case_types
16+
- collection_methods_unrelated_type
1617
- curly_braces_in_flow_control_structures
1718
- depend_on_referenced_packages
1819
- empty_catches
1920
- file_names
2021
- hash_and_equals
21-
- iterable_contains_unrelated_type
22-
- list_remove_unrelated_type
22+
- implicit_call_tearoffs
2323
- no_duplicate_case_values
2424
- non_constant_identifier_names
2525
- null_check_on_nullable_type_parameter
@@ -32,5 +32,6 @@ linter:
3232
- provide_deprecation_message
3333
- unnecessary_overrides
3434
- unrelated_type_equality_checks
35+
- use_string_in_part_of_directives
3536
- valid_regexps
3637
- void_checks

pkgs/lints/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: lints
2-
version: 2.1.2-wip
2+
version: 3.0.0-wip
33
description: >
44
Official Dart lint rules. Defines the 'core' and 'recommended' set of lints
55
suggested by the Dart team.

pkgs/lints/tool/rules.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@
152152
{
153153
"name": "no_wildcard_variable_uses",
154154
"description": "Don't use wildcard parameters or variables.",
155-
"fixStatus": "unregistered"
155+
"fixStatus": "needsEvaluation"
156156
},
157157
{
158158
"name": "prefer_relative_imports",
@@ -182,7 +182,7 @@
182182
{
183183
"name": "unrelated_type_equality_checks",
184184
"description": "Equality operator `==` invocation with references of unrelated types.",
185-
"fixStatus": "noFix"
185+
"fixStatus": "unregistered"
186186
},
187187
{
188188
"name": "unsafe_html",

0 commit comments

Comments
 (0)