Fixes #1976. Update map pattern tests according to the new matching rules #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Mar 31, 2023
eernstg
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
LGTM.
It would be really nice if we could easily see each construct which is intended to be a syntax error (the spec parser rejects many parts of this PR, and it isn't easy to see that it is all about intentional syntax errors).
I adjusted a couple of ^^^^^ lines.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 4, 2023
2023-04-04 [email protected] Fixes dart-lang/co19#1985. Roll failures fixed (dart-lang/co19#1986) 2023-04-04 [email protected] Fixes dart-lang/co19#1983. Typo fixed in type_inference_A22_t01.dart (dart-lang/co19#1984) 2023-04-03 [email protected] Fixes dart-lang/co19#1978. Add processing of HINT.UNREACHABLE_SWITCH_CASE (dart-lang/co19#1982) 2023-04-03 [email protected] dart-lang/co19#1401. Exhaustiveness tests added (dart-lang/co19#1974) 2023-03-31 [email protected] Fixes dart-lang/co19#1976. Runtime errors fixed (dart-lang/co19#1981) 2023-03-31 [email protected] Fixes dart-lang/co19#1976. Update map pattern tests according to the new matching rules (dart-lang/co19#1977) 2023-03-31 [email protected] dart-lang/co19#1401. Additional test for the rest element of a list pattern (dart-lang/co19#1980) Change-Id: I5be25e8f96d081028d68b5086c33b7432f1c8a66 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292883 Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.