Skip to content

get basic windows support working #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2016
Merged

get basic windows support working #80

merged 1 commit into from
Mar 8, 2016

Conversation

jakemac53
Copy link
Contributor

No description provided.

@jakemac53 jakemac53 added this to the v0.2.0 milestone Mar 7, 2016
@kevmoo
Copy link
Member

kevmoo commented Mar 7, 2016

Hello, friend. Have you heard of our lord and savior, pkg/path?

Sooo much better than randomly handing paths n such

@jakemac53
Copy link
Contributor Author

I am using path where relevant, but in most places this package only deals in unix style paths, which is why you still see a fair bit of hardcoded / in there. I tend not to use the path package when dealing with those types of paths because it just adds a lot of boilerplate in that case, and you have to remember to use path.url.* everywhere which is easy to forget and actually more error prone.

@kevmoo
Copy link
Member

kevmoo commented Mar 8, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants