make sure the CachedAssetReader/CachedAssetWriter dont throw synchronously #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah – why not make these methods |
|
Because of the caches, which need to be updated synchronously. For instance given the code: Future.wait(assetIds.map((assetId) => reader.readAsString(assetId)));All of those calls are dispatched synchronously, so the |
| @@ -58,27 +58,41 @@ class CachedAssetReader extends AssetReader { | |||
|
|
|||
| @override | |||
| Future<bool> hasInput(AssetId id) { | |||
There was a problem hiding this comment.
Add comment as to why this is not async – it makes sense now, but docs would help.
|
LGTM – just add comments as to why we don't use |
jakemac53
force-pushed
the
dont-throw-synchronously
branch
from
0cf985e to
0dc9691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The easier solution here would be to just mark all the methods as
async, but we need to deal with the caches in a synchronous fashion. Those same caches can throw however, so wrapping everything in a try/catch seems to be the simplest solution.