Add colors based on severity #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me - what does this do on Windows? |
|
Heh, good question. I will try to figure that out. |
|
OK, I just put in a thing to disable colors on windows for now, as windows support as a whole needs to be evaluated. |
|
I'd vote for a helper function to avoid the logic duplication, but it doesn't seem terribly urgent. Up to you. LGTM. |
jakemac53
force-pushed
the
pretty-logs
branch
from
857c3fd to
2076c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only colors the
[${record.level}]portion, so its not overly obnoxious, lmk what you think.