Add invalidation stress test. #4010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
davidmorgan
force-pushed
the
invalidation-stress-test
branch
from
0b8013e to
054289b
Compare
davidmorgan
force-pushed
the
invalidation-stress-test
branch
from
054289b to
1fda8cf
Compare
Add test cases for, and fix, two bugs it caught.
davidmorgan
force-pushed
the
invalidation-stress-test
branch
from
1fda8cf to
3b85007
Compare
jensjoha
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
Add invalidation stress test, add smaller test cases for and fix two bugs that it found. It also would have caught #3999.
PhasedAssetDepsbug: this is related to but distinct from #3999, the loaded asset deps data was reporting its phase as the first phase with incomplete data, causing data at later phases to be not readable. In fact, it can have incomplete data for arbitrary phases, if the load was scheduled for load at a later phase but no later phase picked up the work because there was no more resolution done. Fix by just treating the data as complete for this case: it won't be used, because the loaded data is only used to reconstruct the import graphs exactly as they were in the previous build.LibraryCycleGraphLoaderbug: the comment states that_idsToLoadis either empty or unchanged; this is not quite true: a recursive call can add work at a later phase; it's possible for a recursive call to add work at the current phase, breaking that invariant. This is unlikely to actually happen in practice, so just fall back to a slower remove.