Add back write caching, simplify caching, use sync I/O #3995
Conversation
PR Health |
davidmorgan
force-pushed
the
write-caching
branch
6 times, most recently
from
e991d71 to
5d163a4
Compare
davidmorgan
changed the title
|
There is a possible issue with memory usage before this PR #3999 So I think it is not good to remove the lru cache and complicate things further :) The write part of the cache needs to not do discards, so that needs a bit of separate logic if keeping the lru cache; it should be a lot simpler now that everything is sync. I'll update the PR to do that then send for review again. Sorry for the noise! |
|
|
||
| /// Pending [readAsBytes] operations. | ||
| final _pendingBytesContentCache = <AssetId, Future<Uint8List>>{}; | ||
| final _bytesContentCache = <AssetId, Uint8List>{}; | ||
|
|
||
| /// Cached results of [exists]. | ||
| /// | ||
| /// Don't bother using an LRU cache for this since it's just booleans. |
| bool exists(AssetId id, {required bool Function() ifAbsent}) { | ||
| final maybeResult = _canReadCache[id]; | ||
| if (maybeResult != null) return maybeResult; | ||
| return _canReadCache[id] = ifAbsent(); |
There was a problem hiding this comment.
I got confused about the _canReadCache name. Maybe _existsCache would make more sense?
|
One thing though, with you changing this anyway: If not too much trouble, could you try doing the sync change as a separate PR? It would be interesting to know how much that changes on its own. |
Thanks--done--yes, it's better to split out. I noticed I should remove all the async methods from |
|
Closing in favour of #4001 |
For #3811.
This is more about adding back functionality removed during the refactoring than performance. The reason write caching was added was to prevent files appearing during the build from causing reanalysis.
But it does seem to be about 10% faster.
FilesystemCacheinvalidateon writing outputs is no longer neededFuture.waitin favour of for loopsPossibly some cache size limit is still a good idea, although for most projects the total source size seen should be small, and there is always the "low resource mode" flag to turn it off.