More inputs invalidation test; fix for deletions #3987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
davidmorgan
force-pushed
the
more-inputs-invalidation-test
branch
from
b4256a9 to
1bc72d3
Compare
davidmorgan
force-pushed
the
more-inputs-invalidation-test
branch
from
1bc72d3 to
cc39f18
Compare
davidmorgan
force-pushed
the
more-inputs-invalidation-test
branch
from
cc39f18 to
6a19676
Compare
davidmorgan
changed the title
jensjoha
approved these changes
Apr 30, 2025
| @@ -513,14 +513,6 @@ void main() { | |||
| expect(globNode.globNodeState!.inputs, contains(coolAssetId)); | |||
| expect(globNode.globNodeState!.results, contains(coolAssetId)); | |||
| await checkChangeType(ChangeType.REMOVE); | |||
| expect( | |||
There was a problem hiding this comment.
I don't understand why is this removed.
There was a problem hiding this comment.
It used to be that the asset graph update would invalidate the glob node and modify the result to remove the deleted node; now it just invalidates the glob node, so in this test it's not updated yet.
I have a work-in-progress PR that refactors away from using the graph to track invalidation, at which point this test goes away altogether.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
More test coverage. I found another bug which is a regression from published behaviour, so the second commit fixes it.
The bug is about a change of input from present->deleted not triggering generation.
The problem is that the graph update code removes inputs if the input was removed, so by the time
_buildShouldRunis reached there is no more record of the dependency. There must have been some code accounting for that case that got simplified away :) ... fix it by keeping the inputs for deleted files, changing the deleted nodes tomissingSourcenodes.