Switch to new resolver, remove old resolver. #3962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Health |
davidmorgan
force-pushed
the
remove-old-resolver
branch
8 times, most recently
from
d074f81 to
38cf987
Compare
davidmorgan
changed the title
davidmorgan
force-pushed
the
remove-old-resolver
branch
from
38cf987 to
45bb9be
Compare
jensjoha
approved these changes
Apr 9, 2025
| if (_runningBuild == null) return false; | ||
|
|
||
| final node = _runningBuild.assetGraph.get(id); | ||
| if (node == null) return false; |
There was a problem hiding this comment.
Previously in this CL I saw that we deleted a file if reading it returned null or something.
Why does a null node here indicate a non-change?
There was a problem hiding this comment.
Null here means it's not in the asset graph, which means it's not a generated file; if you read it once, you'll get the same value by reading it again. So it only needs syncing once.
The dartdoc for the method now says Returns false for all other types of asset, including unknown assets." :)
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811.
Switch to using
AnalysisDriverModelalways, removeBuildAssetUriResolverand--use-experimental-resolverflag.Clean up use of a few utility methods that were in the old file,
assetPathandpackagePath. Move deps parsing now used only by the "transitiveDigestsBuilder" into that file; note that the transitive digests builder is no longer enabled by default, it's not clear if anyone still uses it.As a result of the switch,
AnalysisDriverModelis now used in more tests, make it work :)performResolve, which happen when a read during resolve triggers an earlier phase generated file to be builtreadPhasedinSingleStepReaderWritertrigger builds of generated assets in earlier phases