Skip to content

Remove multi reader #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Conversation

davidmorgan
Copy link
Contributor

@davidmorgan davidmorgan commented Feb 13, 2025

For #3811

Further simplification of test readers in preparation for refactoring the real ones.

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@davidmorgan davidmorgan marked this pull request as ready for review February 14, 2025 08:48
@davidmorgan davidmorgan requested a review from jensjoha February 14, 2025 08:48
sourceAssets: inputAssets,
rootPackage: rootPackage,
);

// Then, read any additionally requested files from the filesystem. These are

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"These are" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@davidmorgan davidmorgan merged commit aa8e27a into dart-lang:master Feb 17, 2025
76 checks passed
@davidmorgan davidmorgan deleted the remove-multi-reader branch February 17, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants