Skip to content

AnalysisDriverModel: update the directive graph on newly-discovered inputs. #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

AnalysisDriverModel: update the directive graph on newly-discovered inputs. #3825

merged 2 commits into from
Feb 5, 2025

Conversation

davidmorgan
Copy link
Contributor

For #3811

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:build 2.4.2 already published at pub.dev
package:build_config 1.1.2 already published at pub.dev
package:build_daemon 4.0.3 already published at pub.dev
package:build_modules 5.0.11 already published at pub.dev
package:build_resolvers 2.4.4-wip WIP (no publish necessary)
package:build_runner 2.4.15-wip WIP (no publish necessary)
package:build_runner_core 8.0.1-dev ready to publish build_runner_core-v8.0.1-dev
package:build_test 2.2.4-wip WIP (no publish necessary)
package:build_web_compilers 4.1.1 already published at pub.dev
package:scratch_space 1.0.3-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

PR Health

jensjoha
jensjoha approved these changes Feb 5, 2025
View reviewed changes
build_resolvers/lib/src/analysis_driver_model.dart Outdated
// TODO(davidmorgan): check if List is faster.
final nextIds = Queue.of(ids);
final processed = <AssetId>{};
final previouslyMissingFiles = <AssetId>{};
while (nextIds.isNotEmpty) {
final nextId = nextIds.removeFirst();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextId doesn't read well... Maybe just id?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@davidmorgan davidmorgan merged commit 81daa03 into dart-lang:master Feb 5, 2025
19 checks passed
@davidmorgan davidmorgan deleted the update-graph-on-new-files branch February 5, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensjoha jensjoha jensjoha approved these changes

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
skip-changelog-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmorgan @jensjoha