Skip to content

Various Windows fixes #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

Various Windows fixes #2001

merged 1 commit into from
Jan 28, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Jan 28, 2019

  • Close the lock file prior to deleting it
  • Properly join and escape paths

This will address dart-lang/webdev#102

@grouma grouma requested a review from jakemac53 January 28, 2019 22:18
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Jan 28, 2019
@grouma grouma merged commit b8c3f16 into master Jan 28, 2019
@grouma grouma deleted the fix-windows branch January 28, 2019 22:52
@grouma grouma mentioned this pull request Jan 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grouma @jakemac53 @googlebot