Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Migrate from deprecated member use #316

Closed
wants to merge 2 commits into from

Conversation

dkrutskikh
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix
[ ] New rule
[ ] Changes an existing rule
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: migrate from deprecated api

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

@dkrutskikh dkrutskikh requested a review from incendial May 8, 2021 19:59
@dkrutskikh dkrutskikh self-assigned this May 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #316 (fa23ff4) into master (9f5e6b8) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   72.52%   72.46%   -0.07%     
==========================================
  Files         137      137              
  Lines        3309     3312       +3     
==========================================
  Hits         2400     2400              
- Misses        909      912       +3     
Impacted Files Coverage Δ
lib/src/analyzer_plugin/analyzer_plugin.dart 0.00% <0.00%> (ø)
.../src/analyzers/lint_analyzer/metrics_analyzer.dart 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5e6b8...fa23ff4. Read the comment docs.

@dkrutskikh dkrutskikh added the type: enhancement New feature or request label May 9, 2021
@dkrutskikh dkrutskikh added this to the 3.3.0 milestone May 9, 2021

dependencies:
analyzer: ^1.4.0
analyzer: ^1.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that this change will not lead to inability to resolve dependencies in dependant projects?

@incendial
Copy link
Member

Closing due to #355

@incendial incendial closed this May 26, 2021
@incendial incendial deleted the migrate-from-deprecated-member-use branch May 26, 2021 14:49
@incendial incendial removed this from the 4.0.0 milestone May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants