Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Force close the http-client on IOAnalytics.close() #155

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Mar 19, 2021

This is part of the solution of: dart-lang/sdk#45235

@google-cla google-cla bot added the cla: yes Google CLA signed label Mar 19, 2021
Copy link

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine... pending connections will also be cancelled by this (at-least when I tested on linux).

@sigurdm sigurdm requested a review from devoncarew March 19, 2021 14:04
Copy link
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@devoncarew
Copy link
Contributor

We can consume this from the sdk w/o a publish, but let me know if you do want a publish.

@sigurdm
Copy link
Contributor Author

sigurdm commented Mar 22, 2021

I'd say let's publish - I added a CHANGELOG entry and version bump.

@devoncarew devoncarew merged commit 5b7317b into dart-archive:master Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Google CLA signed
Development

Successfully merging this pull request may close these issues.

3 participants