Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

update core and recommended from the recent review #136

Merged
merged 2 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
## 2.1.2-wip

- Add 'has quick-fix' checkboxes to the package's readme.
## 3.0.0-wip

- Added to core.yaml:
- `collection_methods_unrelated_type`
- `implicit_call_tearoffs`
- `use_string_in_part_of_directives`
- Removed from core.yaml:
- `iterable_contains_unrelated_type`
- `list_remove_unrelated_type`
- Add info about which lints have quick fixs to the package's readme.

## 2.1.1

Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ To use these lints create an `analysis_options.yaml` file with:
| [`await_only_futures`](https://dart.dev/lints/await_only_futures) | Await only futures. | ✅ |
| [`camel_case_extensions`](https://dart.dev/lints/camel_case_extensions) | Name extensions using UpperCamelCase. | |
| [`camel_case_types`](https://dart.dev/lints/camel_case_types) | Name types using UpperCamelCase. | |
| [`collection_methods_unrelated_type`](https://dart.dev/lints/collection_methods_unrelated_type) | Invocation of various collection methods with arguments of unrelated types. | |
| [`curly_braces_in_flow_control_structures`](https://dart.dev/lints/curly_braces_in_flow_control_structures) | DO use curly braces for all flow control structures. | ✅ |
| [`depend_on_referenced_packages`](https://dart.dev/lints/depend_on_referenced_packages) | Depend on referenced packages. | |
| [`empty_catches`](https://dart.dev/lints/empty_catches) | Avoid empty catch blocks. | ✅ |
| [`file_names`](https://dart.dev/lints/file_names) | Name source files using `lowercase_with_underscores`. | |
| [`hash_and_equals`](https://dart.dev/lints/hash_and_equals) | Always override `hashCode` if overriding `==`. | ✅ |
| [`iterable_contains_unrelated_type`](https://dart.dev/lints/iterable_contains_unrelated_type) | Invocation of Iterable<E>.contains with references of unrelated types. | |
| [`list_remove_unrelated_type`](https://dart.dev/lints/list_remove_unrelated_type) | Invocation of `remove` with references of unrelated types. | |
| [`implicit_call_tearoffs`](https://dart.dev/lints/implicit_call_tearoffs) | Explicitly tear-off `call` methods when using an object as a Function. | ✅ |
| [`no_duplicate_case_values`](https://dart.dev/lints/no_duplicate_case_values) | Don't use more than one case with same value. | ✅ |
| [`non_constant_identifier_names`](https://dart.dev/lints/non_constant_identifier_names) | Name non-constant identifiers using lowerCamelCase. | ✅ |
| [`null_check_on_nullable_type_parameter`](https://dart.dev/lints/null_check_on_nullable_type_parameter) | Don't use null check on a potentially nullable type parameter. | ✅ |
Expand All @@ -128,6 +128,7 @@ To use these lints create an `analysis_options.yaml` file with:
| [`provide_deprecation_message`](https://dart.dev/lints/provide_deprecation_message) | Provide a deprecation message, via @Deprecated("message"). | |
| [`unnecessary_overrides`](https://dart.dev/lints/unnecessary_overrides) | Don't override a method to do a super method invocation with the same parameters. | ✅ |
| [`unrelated_type_equality_checks`](https://dart.dev/lints/unrelated_type_equality_checks) | Equality operator `==` invocation with references of unrelated types. | |
| [`use_string_in_part_of_directives`](https://dart.dev/lints/use_string_in_part_of_directives) | Use string in part of directives. | ✅ |
| [`valid_regexps`](https://dart.dev/lints/valid_regexps) | Use valid regular expression syntax. | |
| [`void_checks`](https://dart.dev/lints/void_checks) | Don't assign to void. | |
<!-- core -->
Expand Down
5 changes: 3 additions & 2 deletions lib/core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ linter:
- await_only_futures
- camel_case_extensions
- camel_case_types
- collection_methods_unrelated_type
- curly_braces_in_flow_control_structures
- depend_on_referenced_packages
- empty_catches
- file_names
- hash_and_equals
- iterable_contains_unrelated_type
- list_remove_unrelated_type
- implicit_call_tearoffs
- no_duplicate_case_values
- non_constant_identifier_names
- null_check_on_nullable_type_parameter
Expand All @@ -32,5 +32,6 @@ linter:
- provide_deprecation_message
- unnecessary_overrides
- unrelated_type_equality_checks
- use_string_in_part_of_directives
- valid_regexps
- void_checks
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: lints
version: 2.1.2-wip
version: 3.0.0-wip
description: >
Official Dart lint rules. Defines the 'core' and 'recommended' set of lints
suggested by the Dart team.
Expand Down
4 changes: 2 additions & 2 deletions tool/rules.json
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
{
"name": "no_wildcard_variable_uses",
"description": "Don't use wildcard parameters or variables.",
"fixStatus": "unregistered"
"fixStatus": "needsEvaluation"
},
{
"name": "prefer_relative_imports",
Expand Down Expand Up @@ -182,7 +182,7 @@
{
"name": "unrelated_type_equality_checks",
"description": "Equality operator `==` invocation with references of unrelated types.",
"fixStatus": "noFix"
"fixStatus": "unregistered"
},
{
"name": "unsafe_html",
Expand Down