This repository was archived by the owner on Nov 20, 2024. It is now read-only.
fix public_member_api_docs overreporting on effectively private constructors
#4535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Jul 5, 2023
| !isPrivate(node.name) && | ||
| node.parent is! EnumDeclaration) { | ||
| check(node); | ||
| if (inPrivateMember(node) || isPrivate(node.name)) return; |
There was a problem hiding this comment.
The code duplication with an earlier PR concerns me. I'm wondering whether we want to add the lines below to inPrivateMember (or add a new utility method to include the overall semantics), maybe making it an extension method in the process.
There was a problem hiding this comment.
Agreed. I've got another PR in the wings for @internal. I'll address this duplication there. Thanks!
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/sdk#59210
/cc @bwilkerson