New rule: Use matching super parameter names #4263
Conversation
srawlins
force-pushed
the
super-name-name
branch
from
1742665 to
d300b59
Compare
|
I'd like to get a little more conversation on the proposal (dart-lang/sdk#59104) before landing. |
|
Sounds good. Anything specific? |
|
As per https://github.com/dart-lang/linter/blob/main/doc/lint-lifecycle.md we generally try and get a bunch of input before "accepting" a proposed lint. I'll go ahead and cc some folks who are reliably opinionated. |
|
|
||
| @override | ||
| void visitConstructorDeclaration(ConstructorDeclaration node) { | ||
| var positionalSuperParameters = node.parameters.parameters |
There was a problem hiding this comment.
I'd be inclined to do this less idiomatically in preference of just one iteration and without all the temporary objects. (I did a series of changes that dumbed down code like this and made it measurably faster.)
There was a problem hiding this comment.
I mean, parameter lists are short but I guess I think every bit counts. 🤔
There was a problem hiding this comment.
FWIW, here's an extreme motivating example: #1838
Implements the proposal at dart-lang/sdk#59104