Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

null assert pattern support for null_check_on_nullable_type_parameter #4148

Merged
merged 3 commits into from
Mar 15, 2023
Merged

null assert pattern support for null_check_on_nullable_type_parameter #4148

merged 3 commits into from
Mar 15, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Mar 14, 2023

@github-actions github-actions bot added the linter-set-core Affects a rule in the core Dart rule set label Mar 14, 2023
@coveralls
Copy link

coveralls commented Mar 14, 2023 •
edited
Loading

Coverage Status

Coverage: 95.66% (+0.004%) from 95.656% when pulling 61d1088 on null_check_on_nullable_type_parameter_nullAssert into 16aa227 on main.

srawlins
srawlins approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks!

@pq pq merged commit a056a0a into main Mar 15, 2023
@pq pq deleted the null_check_on_nullable_type_parameter_nullAssert branch March 15, 2023 16:36
@srawlins srawlins mentioned this pull request Mar 28, 2023
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@pq
null assert pattern support for `null_check_on_nullable_type_paramete…
94bb379 
…r` (dart-archive/linter#4148)

* null assert pattern support for `null_check_on_nullable_type_parameter`

* ++

* fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
linter-set-core Affects a rule in the core Dart rule set
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null_check_on_nullable_type_parameter tests should include null-assert patterns
3 participants
@pq @coveralls @srawlins