Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

unnecessary_null_checks to ignore Future.value and #4079

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

asashour
Copy link
Contributor

Completer.complete.

Fixes dart-lang/sdk#59042

@coveralls
Copy link

Coverage Status

Coverage: 95.671% (+0.006%) from 95.664% when pulling 4f01995 on asashour:4077_unnecessary_null_checks into b96f861 on dart-lang:main.

Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pq pq requested a review from bwilkerson February 16, 2023 23:22
@pq pq merged commit dcf3a07 into dart-archive:main Feb 17, 2023
@asashour asashour deleted the 4077_unnecessary_null_checks branch February 17, 2023 18:02
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

unnecessary_null_checks conflicts with the new NULLABLE_ARGUMENT_TO_NON_NULL_TYPE
4 participants