This repository was archived by the owner on Nov 20, 2024. It is now read-only.
Lint about comparing booleans to boolean literals #3973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oprypin
force-pushed
the
no_literal_bool_comparisons
branch
from
fc290bd to
6612a04
Compare
bwilkerson
reviewed
Jan 9, 2023
bwilkerson
approved these changes
Jan 9, 2023
|
/fyi @MaryaBelanger |
|
Ah and I added a test that this works for any expression, not just a variable. |
|
@oprypin: is this ready to land? |
|
Yes |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
…r#3973) * Lint about comparing booleans to boolean literals * fixup! Lint about comparing booleans to boolean literals * Add test that the lint works for any expression, not just variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lints against any expression like
x == trueorfalse == x.It kicks in only if the variable is of type
bool, non-nullable.Fixes dart-lang/sdk#58533
Ref dart-lang/sdk#58533
Ref dart-lang/sdk#58966