-
Notifications
You must be signed in to change notification settings - Fork 166
Update releasing.md with more pre-release steps #3901
Conversation
@@ -19,9 +33,9 @@ First, make sure the build is GREEN. | |||
All clear? Then: | |||
|
|||
1. Update `pubspec.yaml` with a version bump and `CHANGELOG.md` accordingly. | |||
2. Tag a release [branch](https://github.com/dart-lang/linter/releases). | |||
2. Update Dart SDK's [DEPS](https://github.com/dart-lang/sdk/blob/main/DEPS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new order correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but maybe we can make it clear that we're testing a new release. Maybe there should be a whole new section above for identifying a release candidate.
Like:
All clear? Then:
- Test your candidate release against the SDK, flutter, and Google3 by creating a PR in gerritt.
a. UpdateDEPS
<<--add link-->> to point to your release commit.
b. Upload...
c. Addflutter-analyze
andflutter-engine
try-bots and kick off a build.
Of course, what do next is a bit nuanced... Basically it comes down to fixing as much stuff as you have the power/interest in doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -19,9 +33,9 @@ First, make sure the build is GREEN. | |||
All clear? Then: | |||
|
|||
1. Update `pubspec.yaml` with a version bump and `CHANGELOG.md` accordingly. | |||
2. Tag a release [branch](https://github.com/dart-lang/linter/releases). | |||
2. Update Dart SDK's [DEPS](https://github.com/dart-lang/sdk/blob/main/DEPS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
No description provided.