Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Update releasing.md with more pre-release steps #3901

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

srawlins
Copy link
Contributor

No description provided.

@srawlins srawlins requested a review from pq December 12, 2022 23:10
@@ -19,9 +33,9 @@ First, make sure the build is GREEN.
All clear? Then:

1. Update `pubspec.yaml` with a version bump and `CHANGELOG.md` accordingly.
2. Tag a release [branch](https://github.com/dart-lang/linter/releases).
2. Update Dart SDK's [DEPS](https://github.com/dart-lang/sdk/blob/main/DEPS).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this new order correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but maybe we can make it clear that we're testing a new release. Maybe there should be a whole new section above for identifying a release candidate.

Like:

All clear? Then:

  1. Test your candidate release against the SDK, flutter, and Google3 by creating a PR in gerritt.
    a. Update DEPS <<--add link-->> to point to your release commit.
    b. Upload...
    c. Add flutter-analyze and flutter-engine try-bots and kick off a build.

Of course, what do next is a bit nuanced... Basically it comes down to fixing as much stuff as you have the power/interest in doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@coveralls
Copy link

coveralls commented Dec 12, 2022

Coverage Status

Coverage: 96.421% (+0.8%) from 95.634% when pulling 8536c19 on srawlins-patch-1 into 4b40609 on main.

@@ -19,9 +33,9 @@ First, make sure the build is GREEN.
All clear? Then:

1. Update `pubspec.yaml` with a version bump and `CHANGELOG.md` accordingly.
2. Tag a release [branch](https://github.com/dart-lang/linter/releases).
2. Update Dart SDK's [DEPS](https://github.com/dart-lang/sdk/blob/main/DEPS).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@srawlins srawlins merged commit efa4c97 into main Apr 17, 2023
@srawlins srawlins deleted the srawlins-patch-1 branch April 17, 2023 21:54
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants