This repository was archived by the owner on Nov 20, 2024. It is now read-only.
No adjacent strings in list. Fixes #225. #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Once again I'll defer the approval to @pq or @bwilkerson.
Thank you @dikmax
| const desc = 'Do not use adjacent strings in list'; | ||
|
|
||
| const details = r''' | ||
| **DO NOT** Do not use adjacent strings in list. This can be |
There was a problem hiding this comment.
Remove the second 'Do not'
| @@ -0,0 +1,63 @@ | |||
| // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file | |||
| name: 'no_adjacent_strings_in_list', | ||
| description: desc, | ||
| details: details, | ||
| group: Group.style); |
There was a problem hiding this comment.
I wonder if the group for this is error.
bwilkerson
approved these changes
Nov 28, 2016
|
I've changed group to errors. |
|
We should squash in a single commit before merging, I can do it if needed. |
dikmax
force-pushed
the
225_no_adjacent_stirngs_in_list
branch
from
0593a2a to
8634ae7
Compare
|
No problem. Done it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple rule, but can be useful in some cases.
There're no such lints in SDK and Flutter.