This repository was archived by the owner on Nov 20, 2024. It is now read-only.
enhanced enum support for sort_unnamed_constructors_first
#3248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/rules/all.dart
bwilkerson
approved these changes
Feb 24, 2022
| // Sort members by offset. | ||
| var members = node.members.toList() | ||
| var members = classMembers.toList() | ||
| ..sort((ClassMember m1, ClassMember m2) => m1.offset - m2.offset); |
There was a problem hiding this comment.
I didn't think of this on the last PR, but I'm kind of surprised that we need to sort the members. I thought we already returned them in source order. Not critical, but it would improve performance to not make a pass confirming that everything is already sorted.
There was a problem hiding this comment.
Interesting! I've made a note to loop back and check on this. Thanks!
There was a problem hiding this comment.
Do you think it may be interesting to use a SplayTreeSet instead to keep always the order within the data structure?
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dart-lang/sdk#58642
/cc @bwilkerson