Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

disallow reserved words in package names #2889

Merged
merged 2 commits into from
Aug 24, 2021
Merged

disallow reserved words in package names #2889

merged 2 commits into from
Aug 24, 2021

Conversation

pq
Copy link
Contributor

@pq pq commented Aug 24, 2021

See: #2791 (comment).

Cheers @parlough! 🍻

/cc @bwilkerson

@google-cla google-cla bot added the cla: yes label Aug 24, 2021
@coveralls
Copy link

coveralls commented Aug 24, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 94.009% when pulling 809bcce on disallow_reserved_words_package_names into 5c85d71 on master.

parlough
parlough approved these changes Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me, thanks!

@pq
Copy link
Contributor Author

pq commented Aug 24, 2021

Thanks for catching it!

@pq pq merged commit 3deae6e into master Aug 24, 2021
@pq pq deleted the disallow_reserved_words_package_names branch August 24, 2021 21:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pq @coveralls @bwilkerson @parlough