This repository was archived by the owner on Nov 20, 2024. It is now read-only.
fix issue 1518 #1531
Merged
fix issue 1518 #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
reviewed
Apr 17, 2019
| @@ -96,7 +96,7 @@ class _Visitor extends SimpleAstVisitor<void> { | |||
| } | |||
| if (returnType != null && | |||
| returnType.isDartAsyncFuture && | |||
| type.isAssignableTo(returnType)) { | |||
| type.isSubtypeOf(returnType)) { | |||
There was a problem hiding this comment.
Looks good to me but I'll defer to @bwilkerson for the final call since he may be aware of other implications.
There was a problem hiding this comment.
It seems reasonable to me, and the tests appear to show that it's the right test, but I haven't spent any time to try to prove to myself that it's correct. I say, go for it.
bwilkerson
approved these changes
Apr 18, 2019
| @@ -96,7 +96,7 @@ class _Visitor extends SimpleAstVisitor<void> { | |||
| } | |||
| if (returnType != null && | |||
| returnType.isDartAsyncFuture && | |||
| type.isAssignableTo(returnType)) { | |||
| type.isSubtypeOf(returnType)) { | |||
There was a problem hiding this comment.
It seems reasonable to me, and the tests appear to show that it's the right test, but I haven't spent any time to try to prove to myself that it's correct. I say, go for it.
|
Thanks for taking a look @bwilkerson ! |
pq
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dart-lang/sdk#57934