+ analyzer 5.11.1 (#4314)

* + analyzer 5.11.1

* Failing test fix

* + new warning

Author: pq

lib/src/rules/avoid_double_and_int_checks.dart

@@ -75,8 +75,8 @@ class _Visitor extends SimpleAstVisitor<void> {
   void visitIfStatement(IfStatement node) {
     var elseStatement = node.elseStatement;
     if (elseStatement is IfStatement) {
-      var ifCondition = node.condition;
-      var elseCondition = elseStatement.condition;
+      var ifCondition = node.expression;
+      var elseCondition = elseStatement.expression;
       if (ifCondition is IsExpression && elseCondition is IsExpression) {
         var typeProvider = context.typeProvider;
         var ifExpression = ifCondition.expression;

lib/src/rules/avoid_print.dart

@@ -99,7 +99,7 @@ class _Visitor extends SimpleAstVisitor {
     while (node != null) {
       var parent = node.parent;
       if (parent is IfStatement && node == parent.thenStatement) {
-        var condition = parent.condition;
+        var condition = parent.expression;
         if (condition is SimpleIdentifier &&
             isKDebugMode(condition.staticElement)) {
           return true;

lib/src/rules/literal_only_boolean_expressions.dart

@@ -160,7 +160,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitIfStatement(IfStatement node) {
-    if (_onlyLiterals(node.condition)) {
+    if (_onlyLiterals(node.expression)) {
       rule.reportLint(node);
     }
   }

lib/src/rules/prefer_conditional_assignment.dart

@@ -99,7 +99,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (node.elseStatement != null) {
       return;
     }
-    var expressionInCondition = _getExpressionCondition(node.condition);
+    var expressionInCondition = _getExpressionCondition(node.expression);
     if (expressionInCondition != null &&
         _checkStatement(node.thenStatement, expressionInCondition)) {
       rule.reportLint(node);

lib/src/rules/prefer_null_aware_method_calls.dart

@@ -69,7 +69,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitIfStatement(IfStatement node) {
-    var condition = node.condition;
+    var condition = node.expression;
     if (condition is BinaryExpression &&
         condition.operator.type == TokenType.BANG_EQ &&
         condition.rightOperand is NullLiteral &&

lib/src/rules/unnecessary_parenthesis.dart

@@ -133,8 +133,8 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (parent is ParenthesizedExpression ||
         parent is InterpolationExpression ||
         (parent is ArgumentList && parent.arguments.length == 1) ||
-        (parent is IfStatement && node == parent.condition) ||
-        (parent is IfElement && node == parent.condition) ||
+        (parent is IfStatement && node == parent.expression) ||
+        (parent is IfElement && node == parent.expression) ||
         (parent is WhileStatement && node == parent.condition) ||
         (parent is DoStatement && node == parent.condition) ||
         (parent is SwitchStatement && node == parent.expression) ||

lib/src/rules/use_build_context_synchronously.dart

@@ -183,7 +183,7 @@ class _Visitor extends SimpleAstVisitor {
         }
       } else if (parent is IfStatement) {
         // Only check the actual statement(s), not the IF condition
-        if (child is Statement && parent.condition.hasAwait) {
+        if (child is Statement && parent.expression.hasAwait) {
           rule.reportLint(node);
         }
 
@@ -203,7 +203,7 @@ class _Visitor extends SimpleAstVisitor {
     // their own mounted checks.  The cost of this generality is the possibility
     // of false negatives.
     if (statement is IfStatement) {
-      var condition = statement.condition;
+      var condition = statement.expression;
 
       Expression check;
       if (condition is PrefixExpression) {
@@ -328,7 +328,7 @@ extension on Statement {
   bool get isAsync {
     var self = this;
     if (self is IfStatement) {
-      if (self.condition.hasAwait) return true;
+      if (self.expression.hasAwait) return true;
       if (self.thenStatement.terminatesControl) {
         var elseStatement = self.elseStatement;
         if (elseStatement == null || elseStatement.terminatesControl) {

lib/src/util/condition_scope_visitor.dart

@@ -215,7 +215,7 @@ abstract class ConditionScopeVisitor extends RecursiveAstVisitor {
 
   @override
   void visitIfStatement(IfStatement node) {
-    var elseScope = _visitElseStatement(node.elseStatement, node.condition);
+    var elseScope = _visitElseStatement(node.elseStatement, node.expression);
     _visitIfStatement(node);
     if (elseScope != null) {
       _propagateUndefinedExpressions(elseScope);
@@ -229,10 +229,10 @@ abstract class ConditionScopeVisitor extends RecursiveAstVisitor {
       return;
     }
     if (addFalseCondition) {
-      _addFalseCondition(node.condition);
+      _addFalseCondition(node.expression);
     }
     if (addTrueCondition) {
-      _addTrueCondition(node.condition);
+      _addTrueCondition(node.expression);
     }
   }
 
@@ -391,9 +391,9 @@ abstract class ConditionScopeVisitor extends RecursiveAstVisitor {
 
   void _visitIfStatement(IfStatement node) {
     _addScope();
-    node.condition.accept(this);
-    visitCondition(node.condition);
-    _addTrueCondition(node.condition);
+    node.expression.accept(this);
+    visitCondition(node.expression);
+    _addTrueCondition(node.expression);
     node.thenStatement.accept(this);
     _propagateUndefinedExpressions(_removeLastScope());
   }

pubspec.yaml

@@ -12,7 +12,7 @@ environment:
   sdk: ^3.0.0-0
 
 dependencies:
-  analyzer: ^5.10.0
+  analyzer: ^5.11.1
   args: ^2.1.0
   collection: ^1.15.0
   http: ^0.13.0

test/rules/implicit_reopen_test.dart

@@ -261,9 +261,6 @@ base class D = C with M;
     ]);
   }
 
-  @FailingTest(
-      issue: 'https://github.com/dart-lang/sdk/issues/51891',
-      reason: 'class type aliases cannot be annotated')
   test_classTypeAlias_classBase_classFinal_reopened() async {
     await assertNoDiagnostics(r'''
 import 'package:meta/meta.dart';