validate incompatible rules (#1965)

Author: pq

test/all.dart

@@ -13,7 +13,7 @@ import 'rule_test.dart' as rule_test;
 import 'utils_test.dart' as utils_test;
 import 'validate_format_test.dart' as validate_format;
 import 'validate_headers_test.dart' as validate_headers;
-import 'validate_metadata.dart' as validate_metadata;
+import 'validate_incompatible_rules.dart' as validate_incompatible_rules;
 import 'version_test.dart' as version_test;
 
 void main() {
@@ -28,6 +28,6 @@ void main() {
   utils_test.main();
   validate_format.main();
   validate_headers.main();
-  validate_metadata.main();
+  validate_incompatible_rules.main();
   version_test.main();
 }

test/validate_incompatible_rules.dart

@@ -0,0 +1,27 @@
+// Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:linter/src/analyzer.dart';
+import 'package:linter/src/rules.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('check for incompatible rules:', () {
+    registerLintRules();
+    for (var rule in Analyzer.facade.registeredRules) {
+      for (var incompatibleRule in rule.incompatibleRules) {
+        test(rule.name, () async {
+          var referencedRule = Analyzer.facade.registeredRules
+              .firstWhere((r) => r.name == incompatibleRule);
+          expect(referencedRule, isNotNull,
+              reason:
+                  'No rule found for id: $incompatibleRule (check for typo?)');
+          expect(referencedRule.incompatibleRules, contains(rule.name),
+              reason:
+                  '$referencedRule should define ${rule.name} in `incompatibleRules` but does not.');
+        });
+      }
+    }
+  });
+}