This repository was archived by the owner on Feb 22, 2018. It is now read-only.
make compile command optional, fixes #505 #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vsmenon do you mind taking a look? |
|
BTW, the reason this needs doing now: SDK has a script that passes "--dart-sdk" before the user's arguments. That is not supported by commands in the args package. So DDC is broken in the SDK currently. |
| if (args.isEmpty || args.first != 'compile' && args.first != 'help') { | ||
| // TODO(jmesserly): we should deprecate the commands. For now they are | ||
| // still supported for backwards compatibility. | ||
| args.insert(0, 'compile'); |
There was a problem hiding this comment.
it may not be obvious from this diff view, but if you expand the file above, you can see that we're guaranteed a fresh mutable list (and there's a comment about it).
|
lgtm |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left the commands in there for backwards compatibility, and to make the change easier.
Here is the CL that rolls the SDK forward to this: https://codereview.chromium.org/2065733004