Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

merge analyzer errors with static info #6

Closed
sigmundch opened this issue Dec 16, 2014 · 3 comments
Closed

merge analyzer errors with static info #6

sigmundch opened this issue Dec 16, 2014 · 3 comments

Comments

@sigmundch
Copy link
Contributor

The idea is that we use the same mechanism to report all errors. Currently analyzer errors don't hold a reference to the AstNode, so the integration is not trivial.

One option is to move away from storing static info per node (just store it by offset & length like the analyzer does). This might be OK since the codegen doesn't need all the static info, just some bits here and there.

@jmesserly jmesserly self-assigned this Jun 9, 2015
@jmesserly
Copy link
Contributor

looking into this as part of analyzer_cli integration. Unclear yet if I'll fix it entirely, but starting to look that way.

@jmesserly
Copy link
Contributor

partially fixed in 0ff64c1 ... testChecker no longer depends on nodes. still more work to do to push it all the way back into CodeChecker

@jmesserly
Copy link
Contributor

https://codereview.chromium.org/1230903002/ fixes most of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants