fix analysis messages

seen on the latest dev channel editor w/ analysis server

[email protected]

Review URL: https://codereview.chromium.org/962213003

Author: John Messerly

lib/runtime/dart_runtime.dart

@@ -128,21 +128,7 @@ Arity getArity(Function f) {
   return new Arity._internal(normal, optionalPositional);
 }
 
-bool _isFunctionSubType(TypeMirror t1, TypeMirror t2) {
-  // Function types follow the standard non-Dart rule:
-  // - contravariant on param types
-  // - covariant on return type
-  final f1 = t1 as FunctionTypeMirror;
-  final f2 = t2 as FunctionTypeMirror;
-
-  final params1 = f1.parameters;
-  final params2 = f2.parameters;
-  final ret1 = f1.returnType;
-  final ret2 = f2.returnType;
-  return _isFunctionSubTypeHelper(ret1, params1, ret2, params2);
-}
-
-bool _isFunctionSubTypeHelper(TypeMirror ret1, List<ParameterMirror> params1,
+bool _isFunctionSubType(TypeMirror ret1, List<ParameterMirror> params1,
     TypeMirror ret2, List<ParameterMirror> params2) {
   if (!_isSubType(ret1, ret2)) {
     // Covariant return types
@@ -334,5 +320,5 @@ bool _isSubType(TypeMirror t1, TypeMirror t2) {
   if (_reflects(c2, Function)) return true;
 
   // Check structural function subtyping
-  return _isFunctionSubTypeHelper(ret1, params1, c2.returnType, c2.parameters);
+  return _isFunctionSubType(ret1, params1, c2.returnType, c2.parameters);
 }

lib/src/testing.dart

@@ -287,6 +287,8 @@ class _TestSource implements Source {
 
   bool exists() => true;
 
+  Source get source => this;
+
   String _encoding;
   String get encoding => _encoding != null ? _encoding : (_encoding = '$uri');
 

test/checker/inferred_type_test.dart

@@ -379,7 +379,6 @@ main() {
             final e2 = 1;
           }
       ''',
-      '/e2.dart': '',
       '/f.dart': '''
           part "f2.dart";
       ''',

test/codegen/dir/html_input_c.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+library html_input_c;
+
 import 'html_input_e.dart';
 
 int y = 3 + w;

test/codegen/dom.dart

@@ -20,10 +20,8 @@ class Overload {
 }
 const overload = const Overload();
 
-// TODO(jmesserly): uncomment once fix lands for:
-// https://github.com/dart-lang/dart_style/issues/85
-// @JsGlobal()
-final Document document;
+@JsGlobal()
+final Document document = null;
 
 @JsType(name: 'Document')
 abstract class Document {

test/codegen/fieldtest.dart

@@ -31,7 +31,7 @@ int y = compute() + 444;
 
 String get q => 'life, ' + 'the universe ' + 'and everything';
 int get z => 42;
-int set z(value) {
+void set z(value) {
   y = value;
 }
 

test/codegen_test.dart

@@ -124,7 +124,7 @@ main(arguments) {
           ? path.join(testDir, '..', 'tool', 'input_sdk_src')
           : path.join(testDir, 'generated_sdk');
       var testSdk = new TypeResolver.fromDir(sdkPath, options);
-      var result = compile('dart:core', testSdk, options);
+      compile('dart:core', testSdk, options);
       var outputDir = new Directory(path.join(actualDir, 'core'));
       expect(outputDir.existsSync(), true,
           reason: '${outputDir.path} was created for dart:core');

tool/patch_sdk.dart

@@ -108,7 +108,6 @@ List<String> _patchLibrary(List<String> partsContents, String patchContents) {
   var patchFinder = new PatchFinder.parseAndVisit(patchContents);
 
   // Merge `external` declarations with the corresponding `@patch` code.
-  bool first = true;
   for (var partContent in partsContents) {
     var partEdits = new StringEditBuffer(partContent);
     var partUnit = parseCompilationUnit(partContent);
@@ -138,7 +137,6 @@ class PatchApplier extends GeneralizingAstVisitor {
     // TODO(jmesserly): remove duplicate imports
     var directivePos = unit.directives.last.end;
     for (var directive in patch.unit.directives) {
-      var uri = directive.uri.stringValue;
       var code = patch.contents.substring(directive.offset, directive.end);
       edits.insert(directivePos, '\n' + code);
     }