Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Handle new VM service message format #364

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Feb 3, 2022

"Observatory listening on..." is eventually being updated to "Dart VM
Service listening on...". This change allows for parsing the VM service
URI from messages of either format.

See dart-lang/sdk#46756

"Observatory listening on..." is eventually being updated to "Dart VM
Service listening on...". This change allows for parsing the VM service
URI from messages of either format.

See dart-lang/sdk#46756
@bkonyi bkonyi requested a review from jakemac53 February 3, 2022 18:04
@coveralls
Copy link

coveralls commented Feb 3, 2022

Coverage Status

Coverage remained the same at 90.408% when pulling a4715ad on handle_vm_service_msg into 9a43df0 on master.

Copy link
Contributor

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a CHANGELOG entry?

@bkonyi
Copy link
Contributor Author

bkonyi commented Feb 4, 2022

Can you add a CHANGELOG entry?

Done.

@bkonyi bkonyi merged commit 4fedf9a into master Feb 4, 2022
@bkonyi bkonyi deleted the handle_vm_service_msg branch February 4, 2022 18:21
mosuem pushed a commit to dart-lang/tools that referenced this pull request Aug 28, 2024
"Observatory listening on..." is eventually being updated to "Dart VM
Service listening on...". This change allows for parsing the VM service
URI from messages of either format.

See dart-lang/sdk#46756
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants