Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Use VMScriptRef to identify VM scripts, not URI #216

Merged
merged 1 commit into from
Oct 19, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions lib/src/collect.dart
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,9 @@ Future _waitIsolatesPaused(VMServiceClient service, {Duration timeout}) async {
Future<List<Map<String, dynamic>>> _getCoverageJson(
VMServiceClient service, VMSourceReport report) async {
var scriptRefs = report.ranges.map((r) => r.script).toSet();
var scripts = <Uri, VMScript>{};
for (var script in await Future.wait<VMScript>(
scriptRefs.map((ref) => ref.load()).toList())) {
scripts[script.uri] = script;
var scripts = <VMScriptRef, VMScript>{};
for (var ref in scriptRefs) {
scripts[ref] = await ref.load();
}

// script uri -> { line -> hit count }
Expand All @@ -94,7 +93,7 @@ Future<List<Map<String, dynamic>>> _getCoverageJson(

hitMaps.putIfAbsent(range.script.uri, () => <int, int>{});
var hitMap = hitMaps[range.script.uri];
var script = scripts[range.script.uri];
var script = scripts[range.script];
for (VMScriptToken hit in range.hits ?? []) {
var line = script.sourceLocation(hit).line + 1;
hitMap[line] = hitMap.containsKey(line) ? hitMap[line] + 1 : 1;
Expand All @@ -108,27 +107,26 @@ Future<List<Map<String, dynamic>>> _getCoverageJson(
// Output JSON
var coverage = <Map<String, dynamic>>[];
hitMaps.forEach((uri, hitMap) {
var script = scripts[uri];
coverage.add(_toScriptCoverageJson(script, hitMap));
coverage.add(_toScriptCoverageJson(uri, hitMap));
});
return coverage;
}

/// Returns a JSON hit map backward-compatible with pre-1.16.0 SDKs.
Map<String, dynamic> _toScriptCoverageJson(
VMScript script, Map<int, int> hitMap) {
Uri scriptUri, Map<int, int> hitMap) {
var json = <String, dynamic>{};
var hits = <int>[];
hitMap.forEach((line, hitCount) {
hits.add(line);
hits.add(hitCount);
});
json['source'] = '${script.uri}';
json['source'] = '$scriptUri';
json['script'] = {
'type': '@Script',
'fixedId': true,
'id': 'libraries/1/scripts/${Uri.encodeComponent(script.uri.toString())}',
'uri': '${script.uri}',
'id': 'libraries/1/scripts/${Uri.encodeComponent(scriptUri.toString())}',
'uri': '$scriptUri',
'_kind': 'library',
};
json['hits'] = hits;
Expand Down