This repository was archived by the owner on Jun 20, 2019. It is now read-only.
Fix the type of _convertStatementsBoundAttribute. #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of _convertStatementsBoundAttribute in _convertAttributes has a type error that the analyzer has been failing to detect due to dart-lang/sdk#32305. In order to fix this analyzer bug, we need to first fix any type errors that exist in the wild. This change fixes the type of _convertStatementsBoundAttribute to match the type expected at the use site, and adds the necessary "as" cast.
MichaelRFairhurst
approved these changes
May 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of _convertStatementsBoundAttribute in _convertAttributes has
a type error that the analyzer has been failing to detect due to
dart-lang/sdk#32305. In order to fix this
analyzer bug, we need to first fix any type errors that exist in the
wild.
This change fixes the type of _convertStatementsBoundAttribute to
match the type expected at the use site, and adds the necessary "as"
cast.