CM-1485-do not call setSecret (#333)

Author: watchtower314

packages/common-firebase/env/dev/env_secrets.dev.json

@@ -3,6 +3,6 @@
     "apiKey": "notrealapikey"
   },
   "mail": {
-    "SENDGRID_API_KEY": "SG.Gxxxxx"
+    "SENDGRID_API_KEY": ""
   }
 }

packages/common-firebase/functions/src/notification/email/mailer.ts

@@ -8,11 +8,12 @@ const SENDGRID_APIKEY = 'SENDGRID_APIKEY';
 const setApiKey = async () => {
   const apiKey = await getSecret(SENDGRID_APIKEY);
   sendgrid.setApiKey(apiKey);
+  env.mail.SENDGRID_API_KEY = apiKey;
 }
 
 export const sendMail = async (dest: string, subject: string, message: string, from = env.mail.sender, bcc = null): Promise<void> => {
-  // @question Moore, why are we awaiting this on every single mail we send?
-  await setApiKey();
+  // if env.mail.SENDGRID_API_KEY has no value, set it with apiKey 
+  !env.mail.SENDGRID_API_KEY && await setApiKey();
 
   await sendgrid.send({
     to: dest,