Skip to content

refactor: OpenID strategy and Enhance role extraction and validation logic #6741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
+393 −218
Draft

refactor: OpenID strategy and Enhance role extraction and validation logic #6741

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c77d13d
🔧 feat: Enhance OpenID role extraction and validation logic
rubentalstra Apr 5, 2025
124533f
🔧 test: Update OpenID strategy tests with simulated JWT tokens and im…
rubentalstra Apr 5, 2025
1083014
🔧 feat: Enhance OpenID strategy with improved error handling, role ex…
rubentalstra Apr 5, 2025
f74b9a3
🔧 test: Add fallback test for userinfo roles with invalid id_token
rubentalstra Apr 5, 2025
ec5c9fe
🔧 feat: Add support for PKCE in OpenID strategy configuration
rubentalstra Apr 5, 2025
e5743a0
🔧 refactor: Clean up imports in openidStrategy.js for improved readab…
rubentalstra Apr 5, 2025
b0ebc26
🔧 docs: Add comments for supported algorithms in openidStrategy.js
rubentalstra Apr 5, 2025
81fe64d
🔧 feat: Enhance role extraction logic in OpenID strategy to support m…
rubentalstra Apr 5, 2025
c9b04ef
🔧 chore: Bump version to 0.7.790 in package.json and package-lock.json
rubentalstra Apr 10, 2025
083710d
Merge branch 'main' into refactor/openid-strategy
rubentalstra Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ DOMAIN_CLIENT=http://localhost:3080
DOMAIN_SERVER=http://localhost:3080

NO_INDEX=true
# Use the address that is at most n number of hops away from the Express application.
# req.socket.remoteAddress is the first hop, and the rest are looked for in the X-Forwarded-For header from right to left.
# Use the address that is at most n number of hops away from the Express application.
# req.socket.remoteAddress is the first hop, and the rest are looked for in the X-Forwarded-For header from right to left.
# A value of 0 means that the first untrusted address would be req.socket.remoteAddress, i.e. there is no reverse proxy.
# Defaulted to 1.
TRUST_PROXY=1
Expand Down Expand Up @@ -420,9 +420,12 @@ OPENID_CLIENT_ID=
OPENID_CLIENT_SECRET=
OPENID_ISSUER=
OPENID_SESSION_SECRET=
# OPENID_USE_PKCE=
OPENID_SCOPE="openid profile email"
OPENID_CALLBACK_URL=/oauth/openid/callback
OPENID_REQUIRED_ROLE=
# Set to 'userinfo' or 'token' to determine witch role source to use, Default is 'token'
OPENID_REQUIRED_ROLE_SOURCE=
OPENID_REQUIRED_ROLE_TOKEN_KIND=
OPENID_REQUIRED_ROLE_PARAMETER_PATH=
# Set to determine which user info property returned from OpenID Provider to store as the User's username
Expand Down
Loading